-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom tag for stages image, for build-kit only #160
base: master
Are you sure you want to change the base?
Conversation
Hi @KawtharAlakri. Thank you for your pull request.
Unless I am missing something, I think I am not going to merge this one. |
Hi @whoan |
@KawtharAlakri I have no time to test this now as I am moving but please bear with me I will get to it soon |
@@ -96,9 +96,13 @@ _get_stages_image_name() { | |||
echo "${INPUT_STAGES_IMAGE_NAME:-${INPUT_IMAGE_NAME}-stages}" | |||
} | |||
|
|||
_get_stages_image_tag() { | |||
echo "${INPUT_STAGES_IMAGE_TAG:-latest}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would make all stages to have tags like latest-1, latest-2, ... under legacy behavior (no buildkit) which I don't see it better than current behav.
@KawtharAlakri Could you please clearly state what problem this new attribute is fixing? I tried to put some reasoning about original decision in #157 I am still not sure this is really useful. I can still change |
@whoan Thanks for clarifying your original decision reasoning. However, the issue I faced (and probably the one who created the issue) is that I wanted to use this action in a context where multiple images are being built and stored in the same repository, which requires different naming for their cache to not overlap. and that was the only issue that prevented me from using your action, so I thought it worths some contribution. |
I understand better now. Thanks. Update: Maybe I can use the same image name's tag for the cache? |
This PR supposed to fix the issue #157 and allow custom tag naming for the stages/cache image for build kit.