Create skip_create_repos option (noticeable perf boost for ECR) #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partounian
changed the title
whoan
reviewed
Jan 17, 2024
| @@ -334,7 +338,7 @@ login_to_registry() { | |||
| } | |||
|
|
|||
| create_repos() { | |||
| if ! _can_push; then | |||
| if ! _can_push || ! _skip_create_repos; then | |||
There was a problem hiding this comment.
I think the condition should actually be:
! _can_push || _skip_create_repos
whoan
reviewed
Jan 17, 2024
| @@ -405,7 +409,7 @@ _build_image_buildkit() { | |||
|
|
|||
| local cache_to | |||
| if _can_push; then | |||
| cache_to="--cache-to mode=max,image-manifest=true,type=registry,ref=$cache_image" | |||
| cache_to="--cache-to mode=max,image-manifest=true,type=registry,compression=zstd,ref=$cache_image" | |||
There was a problem hiding this comment.
I prefer to leave the compression=zstd part for a separate (configurable) option as it can increase build time.
|
Close #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.