Skip to content

Commit

Permalink
Revert "Override the default value of `editor.find.seedSearchStringFr…
Browse files Browse the repository at this point in the history
…omSelection` via the `configurationDefaults` contribution point (#1766)"

This reverts commit 9ff6de0.
  • Loading branch information
whitphx authored Nov 12, 2023
1 parent 72515cb commit 53cb9c7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,16 @@ It's an intended design that simulates the original Emacs' behavior.
You can disable it with `emacs-mcx.cursorMoveOnFindWidget` option described below.
See https://github.com/whitphx/vscode-emacs-mcx/issues/137 for the details about this topic.

### The find widget is not initialized with the currently selected string when using `C-s`. It's different from the original VSCode' behavior.
### i-search (`C-s`) is initialized with the currently selected string and the previous search is removed.

This behavior is controlled by `editor.find.seedSearchStringFromSelection` VSCode setting. This extension overrides its default value as `"never"` for the Emacs-like behavior,
while the original VSCode's default value is `"always"`.
This is VSCode's design that an extension cannot control.
To disable it, you should set `editor.find.seedSearchStringFromSelection` VSCode setting as `"never"`.
It makes the find widget work similarly to Emacs.

You can [edit the setting](https://code.visualstudio.com/docs/getstarted/settings) if you prefer a different behavior.
Refs:

- [The official doc about `editor.find.seedSearchStringFromSelection` setting](basics#_seed-search-string-from-selection)
- [The GitHub issue where we discuss about it](https://github.com/whitphx/vscode-emacs-mcx/issues/107)

### The extension has been broken!

Expand Down
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,6 @@
}
}
},
"configurationDefaults": {
"editor.find.seedSearchStringFromSelection": "never"
},
"commands": [
{
"command": "emacs-mcx.addSelectionToNextFindMatch",
Expand Down

0 comments on commit 53cb9c7

Please sign in to comment.