Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commandfor & command attributes to HTMLButtonElement #9841

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
+478 −52
Open

Add commandfor & command attributes to HTMLButtonElement #9841

Changes from 64 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
e1f3111
Add commandfor & command attributes to HTMLButtonElement
keithamus Oct 5, 2023
672183f
fix indentation
keithamus Nov 8, 2024
e4e1c4b
s/and false otherwise/; otherwise false
keithamus Nov 8, 2024
a76843c
remove undeeded comma
keithamus Nov 8, 2024
f65b298
move state outside span
keithamus Nov 8, 2024
4e07504
fix casing in state names
keithamus Nov 8, 2024
a128e7a
drop definitions for attributes mapping to idl definitions
keithamus Nov 8, 2024
719899d
use correct terms for popover show/hide (not open/close)
keithamus Nov 8, 2024
8afb669
more s/, then://
keithamus Nov 8, 2024
c43b2fc
fix indentation
keithamus Nov 8, 2024
eec15ad
reintroduce accidentally removed line break
keithamus Nov 8, 2024
2196384
fixup broken definition for popover visibility state
keithamus Nov 8, 2024
9c93cb2
make commandForElement properly reflect the commandfor attribute
keithamus Nov 8, 2024
934d950
reintroduce the command attribute definition
keithamus Nov 8, 2024
bff3f10
type and simplify the various invoker command steps
keithamus Nov 8, 2024
150eec8
reintroduce the commandfor attribute definition
keithamus Nov 8, 2024
e5a111c
drop attribute reflection and use bespoke algorithms for command mapping
keithamus Nov 9, 2024
f0f3902
attempt to re-define submit button behavior with command/commandfor
keithamus Nov 9, 2024
7a1fe7d
expand command getter steps into a list, always return string
keithamus Nov 10, 2024
871c076
expand type getter steps to ensure "submit" is only returned for vali…
keithamus Nov 10, 2024
05890f8
remove duplicate statement
keithamus Nov 10, 2024
9f60688
s/DOMString?/DOMString/
keithamus Nov 18, 2024
ec6514f
s/Submit/submit
keithamus Nov 18, 2024
a3e56e4
use then over commas
keithamus Nov 18, 2024
b13fc3f
simplify button type steps, avoiding redundant state checks
keithamus Nov 18, 2024
0790c33
switch from or to and for not-submit-button clause
keithamus Nov 18, 2024
74949fe
backlink dom#1328 to the CommandEvent source getter steps
keithamus Nov 25, 2024
8779da9
revert eager line wrapping
keithamus Nov 26, 2024
1166eb4
remove erroneous rebase artefact
keithamus Nov 26, 2024
aa804b6
properly close li
keithamus Nov 26, 2024
729674c
fixup "; return" to ", then return"
keithamus Nov 26, 2024
5a6e582
rephase examples to say "the following code shows"
keithamus Nov 26, 2024
4757ab1
s/Issue/DOM Standard Issue/
keithamus Nov 26, 2024
23dac08
add note for developers, explaining the concept of custom commands
keithamus Nov 26, 2024
7d5fc66
fixup button activation steps to return early for Reset/Submit non-fo…
keithamus Nov 26, 2024
bba3085
apply issue note to event initialisation too
keithamus Nov 26, 2024
8e2d7a6
re-word concept submit button states to include type content-attribut…
keithamus Nov 26, 2024
a3bbc4a
remove erroneous step from rebase
keithamus Nov 26, 2024
4dbb892
add missing "not"
keithamus Nov 26, 2024
21fefc6
reintroduce accidentally remove event target to popover activation step
keithamus Nov 26, 2024
767c4c3
introduce the "custom" state on command attribute table
keithamus Nov 26, 2024
a033ef8
rename "valid custom command" to "custom command keyword"
keithamus Nov 27, 2024
8e6b74e
drop redundant note
keithamus Nov 27, 2024
8d2a17b
use Custom state instead of isCustom bool
keithamus Nov 27, 2024
8e6ae5b
title case all states
keithamus Nov 27, 2024
d6536f1
drop redundant check
keithamus Nov 27, 2024
25d8c9b
properly reference commandfor in code examples
keithamus Nov 27, 2024
eb62a52
remove uneccessary parens
keithamus Nov 27, 2024
8621f0a
suggestions from recent code review
keithamus Nov 27, 2024
44a398d
add definition to attr-button-command-custom
keithamus Nov 27, 2024
0c1dd19
link to buttons and popovers in example
keithamus Nov 27, 2024
e47a66c
fix casing
keithamus Nov 27, 2024
c1c8f42
make "custom command keyword" consistent
keithamus Nov 28, 2024
34e7de8
consitently use span for "custom command keyword"
keithamus Nov 28, 2024
b5c402a
use code not span
keithamus Nov 28, 2024
8b6b4db
s/not false/true
keithamus Nov 28, 2024
15142b8
simplify the show/hidepopover command steps
keithamus Nov 28, 2024
397c490
f code
keithamus Nov 28, 2024
f07be5a
comma
keithamus Nov 28, 2024
224c61d
s/is the .*state/is in the .*state
keithamus Nov 28, 2024
0ce6b7e
more casing fixes
keithamus Nov 28, 2024
c71a1fb
link example commandfor attribute and dialog
keithamus Nov 28, 2024
2cf379a
rework state & attribute value to be a snapshot
keithamus Nov 28, 2024
d2eb8df
redo title casing
keithamus Nov 29, 2024
0a57503
remove accidental ofs
keithamus Nov 29, 2024
d02a649
rephrase "corresponding to" state values
keithamus Dec 4, 2024
9aa7109
s/, return/, then return
keithamus Dec 4, 2024
463df24
line wrapping pass
keithamus Dec 4, 2024
c37596b
address various issues
annevk Dec 4, 2024
35849e7
CI found another place that got improved
annevk Dec 4, 2024
d27d514
fix implicit submit/commandfor button logic
keithamus Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading