Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog light dismiss behavior #10737

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4a93ad6
Add closedby attribute to <dialog>
mfreed7 Oct 31, 2024
3630019
Small tweaks
mfreed7 Oct 31, 2024
32c2240
Add requestClose()
mfreed7 Oct 31, 2024
78f9789
Fix tag nesting
mfreed7 Oct 31, 2024
b99c5ac
Move note out of OL
mfreed7 Nov 1, 2024
8698d0b
Address comments
mfreed7 Nov 8, 2024
f50198e
Check for open attribute
mfreed7 Nov 8, 2024
fb01762
Adjust algorithm to match impl and tests
mfreed7 Nov 13, 2024
4f205bd
Address comments
mfreed7 Nov 13, 2024
38bdafe
Update attribute index
mfreed7 Nov 13, 2024
873e451
Adjustments from dbaron
mfreed7 Nov 14, 2024
e7fbbec
Fix up the return value
mfreed7 Nov 15, 2024
8b019a4
Fix up closewatcher
mfreed7 Nov 15, 2024
b57968e
Fix up ol/li/p
mfreed7 Nov 15, 2024
ea474af
Some cleanup
mfreed7 Nov 15, 2024
db56191
Fix "empty" xref
mfreed7 Nov 15, 2024
82a4561
Address domenic@ comments
mfreed7 Nov 21, 2024
6a9e20b
Address annevk comments
mfreed7 Dec 2, 2024
20dc2fe
Change behavior to only close topmost dialog
mfreed7 Dec 5, 2024
f5a0919
Remove extra section
mfreed7 Dec 6, 2024
3f413d3
Remove exception
mfreed7 Dec 6, 2024
d9ed19f
Add closewatcher override for requestClose
mfreed7 Dec 6, 2024
ff98f98
Address 2 nits
mfreed7 Dec 9, 2024
2fb87b1
Address domenic comments
mfreed7 Dec 10, 2024
6aa7386
Side-step closewatcher abuse prevention
mfreed7 Dec 10, 2024
344d87f
allowPreventClose -> requireHistoryActionActivation
mfreed7 Dec 11, 2024
76619aa
Change closeWatcher.requestClose() also
mfreed7 Dec 12, 2024
57df925
Address two comments
mfreed7 Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading