Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential null use of URL invoking "getting nooopener for window open" on empty url string for window open #10844

Closed
shannonbooth opened this issue Dec 10, 2024 · 0 comments · Fixed by #10847
Assignees

Comments

@shannonbooth
Copy link
Contributor

What is the issue with the HTML Standard?

Repro being:

window.open()

Due to the following sequence:

 3. Let urlRecord be null.
 4. If url is not the empty string, then:
     1. Set urlRecord to the result of encoding-parsing a URL given url, relative to sourceDocument.
     1. If urlRecord is failure, then throw a "SyntaxError" DOMException.
 ...
 9. Let noopener be the result of getting noopener for window open with sourceDocument, tokenizedFeatures, and urlRecord.

With "getting noopener for window open" taking a urlRecord (and never null).

This looks to have been a conflict between the merge requests with #10683 reordering the steps, and then #10731 being applied afterwards.

Interestingly, I think this is because of the branch of #10731 being behind, I can't see the bug present in the spec preview in MR description for either of those merge requests, which is likely how this was missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants