Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improve Repository pattern #1380

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

kaaax0815
Copy link
Member

@kaaax0815 kaaax0815 commented Sep 10, 2024

Description

Improves the Repository Pattern to be more intuitive and developer friendly

Motivation and Context

Previously you had to add a new function to the interface, database provider and database implementation
Also the naming had to be unique and e.g. always append what "table" you are referring to

Now you have to add the function to the Provider for that "table" and implement it in the implementation for that "table"

Database.updateClient -> Database.client.update. This makes it easier to find the right function and what the line of code does

How has this been tested?

Locally

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@kaaax0815 kaaax0815 added this to the v15 milestone Sep 10, 2024
@kaaax0815 kaaax0815 merged commit 0a002a3 into wg-easy:feat-ui Sep 10, 2024
4 checks passed
@kaaax0815 kaaax0815 deleted the feat-repo-pattern branch September 10, 2024 06:42
kaaax0815 added a commit that referenced this pull request Sep 10, 2024
* improve repository pattern

* fix errors
kaaax0815 added a commit that referenced this pull request Dec 17, 2024
* improve repository pattern

* fix errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant