Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to RTCFrameCryptor #123

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Improvements to RTCFrameCryptor #123

merged 7 commits into from
Jun 5, 2024
+103 −66

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Jun 4, 2024 •
edited
Loading

Improvements

  • nil checks
  • Thread safety
  • Fix typo for RTCCryptorAlgorithm

Breaking changes

  • RTCCyrptorAlgorithm renamed to RTCCryptorAlgorithm
  • Initialization of RTCFrameCryptor could return nil.

@hiroshihorie hiroshihorie requested a review from davidzhao June 4, 2024 19:05
@hiroshihorie hiroshihorie changed the title Improvements in RTCFrameCryptor Improvements to RTCFrameCryptor Jun 4, 2024
@hiroshihorie hiroshihorie requested a review from cloudwebrtc June 5, 2024 05:48
@hiroshihorie hiroshihorie merged commit dac8015 into m114_release Jun 5, 2024
@hiroshihorie hiroshihorie deleted the hiroshi/nil-safe-framecryptor branch June 5, 2024 05:55
cloudwebrtc added a commit that referenced this pull request Jun 12, 2024
@cloudwebrtc @theomonnom
@hiroshihorie @davidliu
Frame Cryptor Support.
fc08745 
feat: Frame Cryptor (aes gcm/cbc). (#54)
feat: key ratchet/derive. (#66)
fix: skip invalid key when decryption failed. (#81)
Improve e2ee, add setSharedKey to KeyProvider. (#88)
add failure tolerance for framecryptor. (#91)
fix h264 freeze. (#93)
Fix/send frame cryptor events from signaling thread (#95)
more improvements for E2EE. (#96)
remove too verbose logs (#107)
Add key ring size to keyProviderOptions. (#109)
Improvements to RTCFrameCryptor (#123)

Co-authored-by: Théo Monnom <[email protected]>
Co-authored-by: Hiroshi Horie <[email protected]>
Co-authored-by: davidliu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@cloudwebrtc cloudwebrtc Awaiting requested review from cloudwebrtc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroshihorie @davidzhao