fix: facebook photos page scroll

We now track the first photo clicked, and stop once that one is found again
webrecorder · Sep 14, 2023 · 9ebc18d · 9ebc18d
1 parent de518a8
commit 9ebc18d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/site/facebook.ts b/src/site/facebook.ts
@@ -14,7 +14,7 @@ const Q = {
   commentMoreComments: "./following-sibling::div/div/div[2][@role='button'][./span/span]",
   viewComments: ".//h4/..//div[@role='button']",
   photoCommentList: "//ul[../h2]",
-  firstPhotoThumbnail: "//div[@role='main']//div[3]//div[contains(@style, 'border-radius')]//div[contains(@style, 'max-width') and contains(@style, 'min-width')]//a[@role='link']",
+  firstPhotoThumbnail: "//*[@id=\"mount_0_0_4m\"]/div/div[1]/div/div[3]/div/div/div/div[1]/div[1]/div/div/div[4]/div/div/div/div/div/div/div/div/div[3]/div[1]/div[1]/div/div/a",
   firstVideoThumbnail: "//div[@role='main']//div[contains(@style, 'z-index')]/following-sibling::div/div/div/div[last()]//a[contains(@href, '/videos/') and @aria-hidden!='true']",
   firstVideoSimple: "//div[@role='main']//a[contains(@href, '/videos/') and @aria-hidden!='true']",
   mainVideo: "//div[@data-pagelet='root']//div[@role='dialog']//div[@role='main']//video",
@@ -275,6 +275,7 @@ export class FacebookTimelineBehavior {
     firstPhoto.click();
     await sleep(waitUnit * 5);
     await waitUntil(() => window.location.href !== lastHref, waitUnit * 2);
+    const firstPhotoHref = window.location.href;
 
     let nextSlideButton = null;
 
@@ -290,7 +291,8 @@ export class FacebookTimelineBehavior {
         sleep(3000)
       ]);
 
-      if (window.location.href === lastHref) {
+      // Exit once we've looped
+      if (window.location.href === firstPhotoHref) {
         break;
       }