Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update listen and close deprecation warning message #4097

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

update listen and close deprecation warning message.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #4097 (9b67774) into master (2e85dd1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4097   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          14       14           
  Lines        1481     1481           
  Branches      547      547           
=======================================
  Hits         1374     1374           
  Misses         99       99           
  Partials        8        8           
Impacted Files Coverage Δ
lib/Server.js 94.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e85dd1...9b67774. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when CI will be green

@snitin315 snitin315 merged commit b217a19 into master Dec 10, 2021
@snitin315 snitin315 deleted the fix/typo-in-dep-warning branch December 10, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants