Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct schema for ClientLogging #4084

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes, updated snapshots.

Motivation / Use-Case

Fix typo in schema.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #4084 (bcdd5b6) into master (79a169b) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
+ Coverage   92.70%   92.84%   +0.13%     
==========================================
  Files          14       14              
  Lines        1481     1481              
  Branches      547      547              
==========================================
+ Hits         1373     1375       +2     
+ Misses        100       98       -2     
  Partials        8        8              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a169b...bcdd5b6. Read the comment docs.

@snitin315 snitin315 force-pushed the fix-schema-clientlogging branch from 2bf00e7 to bcdd5b6 Compare December 8, 2021 02:54
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rishabh3112 rishabh3112 merged commit 9b7ae7b into master Dec 8, 2021
@rishabh3112 rishabh3112 deleted the fix-schema-clientlogging branch December 8, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants