-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add setupMiddlewares
option
#4068
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4068 +/- ##
==========================================
+ Coverage 92.25% 92.54% +0.29%
==========================================
Files 14 14
Lines 1484 1462 -22
Branches 548 552 +4
==========================================
- Hits 1369 1353 -16
+ Misses 107 101 -6
Partials 8 8
Continue to review full report at Codecov.
|
6768a2a
to
911a5e5
Compare
911a5e5
to
8a31a9a
Compare
Refactored and updated examples + improve perf for |
Also refactor some places, so we now try to use |
@snitin315 Ideally we need add new options |
Yes, I think we can create a separate pipeline for |
@snitin315 I was wrong, we need |
The API is not easy to understand like before, what's the advantage of |
What is misleading? It was implemented to allow developers use own middlewares and even replaces built-in |
For Bugs and Features; did you add new tests?
Yes.
Motivation / Use-Case
TODO:
onAfterSetupMiddleware
andonBeforeSetupMiddleware
.Breaking Changes
None
Additional Info
No