Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add summary to smoketests #3288

Merged
merged 2 commits into from
Jun 10, 2022
Merged

feat: add summary to smoketests #3288

merged 2 commits into from
Jun 10, 2022

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
No Need

Summary
It is difficult to detect which test passed and which one failed on CI. Added a summary at the end of run to make it easier.
image

Does this PR introduce a breaking change?
Nope

Other information
Nope

@rishabh3112 rishabh3112 requested a review from a team as a code owner June 10, 2022 04:47
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3288 (b1cb5de) into master (1072e38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3288   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files          23       23           
  Lines        1731     1731           
  Branches      519      519           
=======================================
  Hits         1594     1594           
  Misses        137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1072e38...b1cb5de. Read the comment docs.

Copy link
Member Author

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated output, Looks like one below:
image

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabh3112 rishabh3112 merged commit 652cc70 into master Jun 10, 2022
@rishabh3112 rishabh3112 deleted the feat/smoketest-summary branch June 10, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants