perf: simplify logic, reduce extra loops and perf (#3767)

webpack · May 7, 2023 · 6afe1d3 · 6afe1d3
1 parent 10165f8
commit 6afe1d3
Show file tree

Hide file tree

Showing 7 changed files with 225 additions and 144 deletions.
diff --git a/packages/serve/src/index.ts b/packages/serve/src/index.ts
@@ -193,7 +193,7 @@ class ServeCommand {
             for (const path in problemsByPath) {
               const problems = problemsByPath[path];
 
-              problems.forEach((problem: Problem) => {
+              for (const problem of problems) {
                 cli.logger.error(
                   `${cli.capitalizeFirstLetter(problem.type.replace(/-/g, " "))}${
                     problem.value ? ` '${problem.value}'` : ""
@@ -205,7 +205,7 @@ class ServeCommand {
                 if (problem.expected) {
                   cli.logger.error(`Expected: '${problem.expected}'`);
                 }
-              });
+              }
             }
 
             process.exit(2);

diff --git a/packages/webpack-cli/src/types.ts b/packages/webpack-cli/src/types.ts
@@ -100,7 +100,6 @@ interface WebpackCLIConfig {
 interface WebpackCLICommand extends Command {
   pkg: string | undefined;
   forHelp: boolean | undefined;
-  options: WebpackCLICommandOption[];
   _args: WebpackCLICommandOption[];
 }
 
@@ -187,10 +186,7 @@ type Callback<T extends unknown[]> = (...args: T) => void;
 /**
  * Webpack
  */
-type WebpackConfiguration = Configuration & {
-  // TODO add extends to webpack types
-  extends?: string | string[];
-};
+type WebpackConfiguration = Configuration;
 type ConfigOptions = PotentialPromise<WebpackConfiguration | CallableOption>;
 type CallableOption = (env: Env | undefined, argv: Argv) => WebpackConfiguration;
 type WebpackCompiler = Compiler | MultiCompiler;
@@ -209,7 +205,6 @@ type FileSystemCacheOptions = WebpackConfiguration & {
 
 type ProcessedArguments = Record<string, BasicPrimitive | RegExp | (BasicPrimitive | RegExp)[]>;
 
-type MultipleCompilerStatsOptions = StatsOptions & { children: StatsOptions[] };
 type CommandAction = Parameters<WebpackCLICommand["action"]>[0];
 
 interface WebpackRunOptions extends WebpackOptionsNormalized {
@@ -339,7 +334,6 @@ export {
   Instantiable,
   JsonExt,
   ModuleName,
-  MultipleCompilerStatsOptions,
   PackageInstallOptions,
   PackageManager,
   Path,