refactor: update types

webpack · Jun 6, 2023 · 3a765d9 · 3a765d9
1 parent f5677bc
commit 3a765d9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/lib/ResolverFactory.js b/lib/ResolverFactory.js
@@ -50,7 +50,8 @@ const UseFilePlugin = require("./UseFilePlugin");
 /** @typedef {string|string[]|false} AliasOptionNewRequest */
 /** @typedef {{[k: string]: AliasOptionNewRequest}} AliasOptions */
 /** @typedef {{[k: string]: string|string[] }} ExtensionAliasOptions */
-/** @typedef {{apply: function(Resolver): void} | function(this: Resolver, Resolver): void} Plugin */
+/** @typedef {false | 0 | "" | null | undefined} Falsy */
+/** @typedef {{apply: function(Resolver): void} | (function(this: Resolver, Resolver): void) | Falsy} Plugin */
 
 /**
  * @typedef {Object} UserResolveOptions

diff --git a/test/plugins.test.js b/test/plugins.test.js
@@ -44,6 +44,8 @@ describe("plugins", function () {
 		const resolver = ResolverFactory.createResolver({
 			fileSystem: require("fs"),
 			plugins: [
+				0,
+				"",
 				false,
 				null,
 				undefined,

diff --git a/types.d.ts b/types.d.ts
@@ -281,6 +281,11 @@ declare interface ParsedIdentifier {
 	internal: boolean;
 }
 type Plugin =
+	| undefined
+	| null
+	| false
+	| ""
+	| 0
 	| { apply: (arg0: Resolver) => void }
 	| ((this: Resolver, arg1: Resolver) => void);
 declare interface PnpApiImpl {