fix: incorrect handling of non-mutated class names #448
Conversation
|
cc @d3viant0ne I believe the release of |
joscha
force-pushed
the
joscha/fix-only-option
branch
from
7d859b2 to
eb130b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 98.41% 98.47% +0.05%
==========================================
Files 9 9
Lines 315 327 +12
Branches 72 74 +2
==========================================
+ Hits 310 322 +12
Misses 5 5
Continue to review full report at Codecov.
|
|
|
||
| var targetKey; | ||
| if (camelCaseKeys === true || camelCaseKeys === 'only') { | ||
| targetKey = camelCase(key); | ||
| if (targetKey !== key) { |
There was a problem hiding this comment.
this line was the culprit, as it would prevent the camelcased key to be added to the locals only if it was different from the default key. However with the only and dashesOnly options the default key would not have been added -> empty locals.
|
Thank you @bebraw! And sorry about the hassle. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the README?
n/a
Summary
When converting a class name without dashes, the newly introduced
'only'and'dashesOnly'settings for thecamelCaseoption would only ever add the class name to locals if it was different to the standard class name. Any class w/o dash would therefore not be added to the locals at all.Does this PR introduce a breaking change?
No
Other information
Introduced in #445 - released in
0.27.0