Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Added for-loop-iteration hint #4103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruppysuppy
Copy link
Contributor

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Added for..in and for..of loop hint in case of improper use


Fixes: #4018

@ruppysuppy
Copy link
Contributor Author

ruppysuppy commented Nov 5, 2020

I haven't started working on the hint functionality as of yet (added the readme and other nits). How do I extract the information from the AST?

@antross antross added the agenda label Jan 5, 2021
@antross
Copy link
Member

antross commented Jan 15, 2021

Hey @ruppysuppy sorry for the slow response. Taking a look at this I don't see the AST information available either.

I think we may need to do some more work in our parser-typescript to attach this information to the AST. In that case we may want to put this on hold for the moment and I'll let you know once we have the AST information available (unless you want to see what you can figure out with the TypeScript parser in the meantime).

@ruppysuppy
Copy link
Contributor Author

I will wait till the data is attached to the AST. Please leave a comment in this PR, I will continue from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hint] Pitfalls - Using for..in with an Array/Iterable (or for..of with an object)
2 participants