Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #983: New issues not getting browser labels #984

Merged
merged 2 commits into from
Mar 31, 2016
Merged

Fixes #983: New issues not getting browser labels #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9806d6
Issue #983: Removed trailing space
Mar 29, 2016
ef1abcb
Issue #983: Fix failing unit test
Mar 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
TABLET_UA = "Mozilla/5.0 (Android 4.4; Tablet; rv:41.0) Gecko/41.0 Firefox/41.0" # nopep8
PARSED_NON_TABLET_BROWSER_NAME = "firefox mobile"
PARSED_TABLET_BROWSER_NAME = "firefox mobile tablet"
PARSED_NON_TABLET_BROWSER = "Firefox Mobile 40.0 "
PARSED_NON_TABLET_BROWSER = "Firefox Mobile 40.0"
PARSED_TABLET_BROWSER = "Firefox Mobile 41.0 (Tablet)"


Expand Down
4 changes: 2 additions & 2 deletions webcompat/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ def get_browser(user_agent_string):
version = ''
# Check for tablet devices
if ua_dict.get('device').get('model') == 'Tablet':
model = '(Tablet)'
model = ' (Tablet)'
else:
model = ''
return '{0} {1} {2}'.format(name, version, model)
return '{0} {1}{2}'.format(name, version, model)


def get_os(user_agent_string):
Expand Down