Fixes #730. Focus and blur the search input when opening and closing. #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blah, ignore the test failures. I'm working on that in #728 |
| @@ -48,7 +48,7 @@ | |||
| <span class="wc-Navbar-link-icon wc-Icon wc-Icon--search" aria-hidden="true"></span> | |||
| </div> | |||
| <input class="wc-SearchBar-input" autofocus name="q" placeholder="Search by keyword"/> | |||
| <button class="r-ResetButton wc-SearchBar-icon wc-SearchBar-icon--button js-SearchBarClose" ara-hidden="true"> | |||
| <button class="r-ResetButton wc-SearchBar-icon wc-SearchBar-icon--button js-SearchBarClose" ara-hidden="true" type="button"> | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
magsout
added a commit
that referenced
this pull request
Oct 1, 2015
Fixes #730. Focus and blur the search input when opening and closing.
|
r+ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @magsout
I also noticed that the close button was submitting the form, apparently the default type for
<button>istype=submit. TIL.