Adds two working tests for labels and a setup for the login #272 #666

karlcow · 2015-08-06T05:59:37Z

setup login
check the gear is available
add contactready

…ams.

… issue models.

… w/ namespace removed.

…iginal repo labels.

karlcow · 2015-08-06T06:01:35Z

I had initially added a test for removing the contactready label, but the slowness of communication with github. Makes it difficult to test. I will create another set of tests.

A note the way we currently test is not perfect because we tested that our UI is working well, not that the label has been sent to github. We should probably do a reload of the page and then see if the test has been setup (which is shouting for mockup ;) )

tests/functional/labels.js

+      return this.remote
+        .setFindTimeout(intern.config.wc.pageLoadTimeout)
+        .get(require.toUrl(url(100)))
+        .findByCssSelector('.js-login-link').click()


Fixes webcompat#656. Add tests to prevent regression stage filter params.

Fixes webcompat#660. Move all label namespace handling to models.

miketaylr · 2015-08-06T16:36:15Z

A note the way we currently test is not perfect because we tested that our UI is working well, not that the label has been sent to github.

You could test for the presence of a flash error message. We send those if the communication with GitHub fails: https://github.com/webcompat/webcompat.com/blob/master/webcompat/static/js/lib/models/issue.js#L131

But re-loading the page and checking for the label also seems good.

dependency on the previous test.

karlcow · 2015-08-13T05:40:59Z

ok :)

PASS: main - labels - label gear is visible (246ms)
PASS: main - labels - label widget is opening on click (352ms)
PASS: main - labels - Label appears once selected (445ms)
PASS: main - labels - Label has been sent to GitHub (3349ms)
PASS: main - labels - Removes a label (5063ms)
0/5 tests failed
0/5 tests failed

@miketaylr apart of the setup with the login process, this is PR ready.

miketaylr · 2015-08-13T15:54:08Z

Awesome @karlcow. Can you squash your PR down to just a few commits? 36 is a lot. ^_^

tests/intern.js

@@ -37,7 +37,7 @@ define(['intern/lib/args'], function (args) {
    functionalSuites: [ 'tests/functional' ],

    // A regular expression matching URLs to files that should not be included in code coverage analysis
-    excludeInstrumentation: /./
+    excludeInstrumentation: /\./


karlcow · 2015-08-13T22:36:23Z

@miketaylr will 6 or 7 commits be acceptable (one per test) 🔨 😈

miketaylr · 2015-08-13T22:43:28Z

@karlcow haha yeah. I should have specified it would be nice to not merge back in the older commits (from myself).

karlcow · 2015-08-13T22:49:00Z

@miketaylr ok :) thanks. I think I will destroy this one and recreate a new branch starting from the last version of master. And re-play the commits. thanks. It seems easier.

karlcow · 2015-08-14T05:53:09Z

Closing this one in favor of #675

Mike Taylor and others added 14 commits August 3, 2015 18:57

Issue webcompat#656. Add tests to prevent regression stage filter par…

7362e53

…ams.

Issue 660. Update lodash.

ead3a84

Issue webcompat#660. Add a removeNamespaces method to both labels and…

d347fce

… issue models.

Issue webcompat#660. Remove various namespace operations.

1c5eaca

Issue webcompat#660. Keep a set of original labels, as well as labels…

e67322e

… w/ namespace removed.

Issue webcompat#660. Construct a labelsToUpdate array based on the or…

b2c3cc1

…iginal repo labels.

Issue webcompat#660. Use _.bind() rather than self.

b7eb659

Issue webcompat#660. Update comments in updateLabels.

7b58903

webcompat#272 fixing a couple of jslint

dd1b323

webcompat#272 Adds a labels tests section

d122e71

webcompat#272 Adds login to the site

f430106

webcompat#272 tests if label gear is visible

332f0d6

webcompat#272 tests the addition of contactready label

18b81c8

webcompat#272 move the login to the setup

94dce03

karlcow added the status: in progress label Aug 6, 2015

karlcow changed the title ~~Adds two working tests for labels and a setup for the login~~ Adds two working tests for labels and a setup for the login #272 Aug 6, 2015

karlcow mentioned this pull request Aug 6, 2015

tests: labels #272

Closed

7 tasks

miketaylr reviewed Aug 6, 2015
View reviewed changes

Mike Taylor added 2 commits August 6, 2015 11:32

Merge pull request webcompat#657 from webcompat/issues/656/1

77ddeab

Fixes webcompat#656. Add tests to prevent regression stage filter params.

Merge pull request webcompat#661 from webcompat/issues/660/1

4555010

Fixes webcompat#660. Move all label namespace handling to models.

Mike Taylor and others added 8 commits August 6, 2015 12:00

v1.6.11 changelog update.

a1faa33

webcompat#272 fixing a couple of jslint

e62c8a6

webcompat#272 Adds a labels tests section

4dba576

webcompat#272 Adds login to the site

33ce6f1

webcompat#272 tests if label gear is visible

5c4c500

webcompat#272 tests the addition of contactready label

e9d8c64

webcompat#272 move the login to the setup

d298d2c

webcompat#272 adds test for label editor widget opening

6f4da8f

karlcow added 12 commits August 10, 2015 14:31

Merge branch '272/2' of github.com:karlcow/webcompat.com into 272/2

9553491

webcompat#272 renames the test to be more exact

15f7ce3

webcompat#272 adds comments about login state

f401b1e

webcompat#272 Changes issue number for running tests

0ee89fa

webcompat#272 fixing registerSuite and context of url

e398593

webcompat#272 fixing setup

8ef83da

webcompat#272 label gear is visible

f27176e

webcompat#272 moving label is selected

9744c95

webcompat#272 widget opened on a click

fa03203

webcompat#272 label sent to github

4bfa1b1

webcompat#272 remove label

a4cf13d

dependency on the previous test.

teardown. Not sure it is working as I expect

5f5fa09

karlcow self-assigned this Aug 13, 2015

miketaylr reviewed Aug 13, 2015
View reviewed changes

karlcow closed this Aug 14, 2015

karlcow removed the status: in progress label Aug 14, 2015

karlcow deleted the 272/2 branch August 14, 2015 05:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds two working tests for labels and a setup for the login #272 #666

Adds two working tests for labels and a setup for the login #272 #666

karlcow commented Aug 6, 2015

karlcow commented Aug 6, 2015

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Aug 6, 2015

karlcow commented Aug 13, 2015

miketaylr commented Aug 13, 2015

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented Aug 13, 2015

miketaylr commented Aug 13, 2015

karlcow commented Aug 13, 2015

karlcow commented Aug 14, 2015

Adds two working tests for labels and a setup for the login #272 #666

Adds two working tests for labels and a setup for the login #272 #666

Conversation

karlcow commented Aug 6, 2015

karlcow commented Aug 6, 2015

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Aug 6, 2015

karlcow commented Aug 13, 2015

miketaylr commented Aug 13, 2015

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented Aug 13, 2015

miketaylr commented Aug 13, 2015

karlcow commented Aug 13, 2015

karlcow commented Aug 14, 2015