Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3392 - Refactor css after original form removal #3416

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jul 27, 2020

In this PR I've deleted unused css and also refactored styles to make wizard input styles be the default input styles for the site.

display: flex;
flex-wrap: wrap;
justify-content: space-between;
margin-left: -10px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes are no longer in use after deleting form.html

@ksy36 ksy36 requested a review from miketaylr July 27, 2020 23:42
@karlcow karlcow linked an issue Jul 28, 2020 that may be closed by this pull request
@miketaylr
Copy link
Member

It would be good for @magsout to take a look when he's back from vacation, but no need to block on that. Guillaume, if you have feedback after the fact, please file an issue!

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I looked at this locally as well and don't notice anything obviously wrong when comparing to the production site.

@miketaylr miketaylr merged commit abcd840 into master Jul 28, 2020
@miketaylr miketaylr deleted the issue/3392-css/1 branch July 28, 2020 18:22
@ksy36
Copy link
Contributor Author

ksy36 commented Jul 28, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove HTML and CSS code associated with the old form
2 participants