fixes #3208 - Moves to boolean flag for anonymous reporting #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ha a couple of things to fix This is logical. :) |
|
ok fixed. |
ksy36
reviewed
Feb 21, 2020
|
|
||
| if ANONYMOUS_REPORTING_ENABLED in ['True', 'False']: | ||
| ANONYMOUS_REPORTING_ENABLED = strtobool(ANONYMOUS_REPORTING_ENABLED) |
There was a problem hiding this comment.
Maybe a comment explaining that env variable is a string would be helpful here for the future?
ksy36
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3208
Proposed PR background
It reenables the boolean flag for our code wrt anonymous reporting, which is a bit more elegant.
This requires to change the environment variable on the server when deploying.