Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3150 - Send the "moderation in process" message to the public issue #3156

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Fixes #3150 - Send the "moderation in process" message to the public issue #3156

merged 2 commits into from
Jan 15, 2020

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jan 15, 2020 •
edited by karlcow
Loading

r? @karlcow or @miketaylr

closes #3137
closes #3150

@ksy36 ksy36 changed the title Fixes 3150 Fixes #3150 Jan 15, 2020
@ksy36 ksy36 changed the title Fixes #3150 Fixes #3150 - Send the "moderation in process" message to the public issue Jan 15, 2020
karlcow
karlcow requested changes Jan 15, 2020
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksy36 Thanks for the code! :) just a minor style issue. fix it and rebase and push -f and then we are good.

webcompat/issues.py Outdated Show resolved Hide resolved
@ksy36
Copy link
Contributor Author

ksy36 commented Jan 15, 2020

could you please take another look @karlcow

karlcow
karlcow reviewed Jan 15, 2020
View reviewed changes
webcompat/issues.py Outdated Show resolved Hide resolved
karlcow
karlcow reviewed Jan 15, 2020
View reviewed changes
webcompat/issues.py Outdated Show resolved Hide resolved
karlcow
karlcow approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ksy36 Let's approve. 🎡
I just changed one minor thing.

@karlcow karlcow merged commit fe77bc3 into master Jan 15, 2020
@karlcow karlcow mentioned this pull request Jan 15, 2020
Merged
@miketaylr miketaylr deleted the issue/3150/1 branch January 15, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

@miketaylr miketaylr miketaylr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send the "moderation in process" message to the public issue Create copy for 2 moderation scenarios
3 participants
@ksy36 @miketaylr @karlcow