Fixes #2750 - Improves text rendering #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow this is weird. Why my PR isn't being tested? |
indeed. |
karlcow
changed the title
marimeireles
force-pushed
the
issues/2750/2
branch
from
a28bd18 to
9b9bc23
Compare
|
@karlcow 🐄 |
|
yoohoo @marimeireles Hello and welcome back. |
karlcow
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the previous discussion we had here: #2808
I decided to create a new version so we still keep a log from the discussion we had about trying to use the
fontfaceobserver.There are two changes in this PR.
@font-face. The reason why I added it can be found in this Enable text compression #2750 (comment) but summarizing I think thefont-display: optionaloption can have a huge impact for users in slow internet connections showing text for them much earlier + this is super easy to implement.@miketaylr these are the changes I proposed here #2808 (comment).