Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1535 - added Pagination below the list #1589

Merged
merged 2 commits into from
Jun 28, 2017
Merged

Fixes #1535 - added Pagination below the list #1589

merged 2 commits into from
Jun 28, 2017

Conversation

magsout
Copy link
Member

@magsout magsout commented Jun 9, 2017

@magsout magsout requested a review from zoepage June 9, 2017 19:43
@zoepage
Copy link
Member

zoepage commented Jun 10, 2017

@magsout You are on 🔥 right now! Wow! Good job! :)

The change looks good. There is just one tiny thing I was wondering about.

When I click for example next, it gets a highlight. But just the one I've clicked (clicked the upper one). Wanna take a look at that? :)

screen shot 2017-06-10 at 11 49 50 am

screen shot 2017-06-10 at 11 49 55 am

@magsout
Copy link
Member Author

magsout commented Jun 21, 2017

@zoepage

Hum, it's because of the :focus https://github.com/webcompat/webcompat.com/blob/master/webcompat/static/css/development/components/pagination.css#L28

Remove that line fixes the issue, but don't know about accessibility..

@zoepage
Copy link
Member

zoepage commented Jun 21, 2017

@magsout I see. Focus should have an outline when we talk about accessibility standards... 🤔

@magsout
Copy link
Member Author

magsout commented Jun 27, 2017

@zoepage so we can remove it?

@zoepage
Copy link
Member

zoepage commented Jun 27, 2017

@magsout +1

@magsout
Copy link
Member Author

magsout commented Jun 28, 2017

@zoepage done

@zoepage
Copy link
Member

zoepage commented Jun 28, 2017

Cool! Thanks for your work @magsout <3

@zoepage zoepage merged commit 2cb491c into master Jun 28, 2017
@zoepage zoepage deleted the issues/1535 branch June 28, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoepage zoepage Awaiting requested review from zoepage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magsout @zoepage @miketaylr