New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Flask-Upload and implement our own upload backend #882

Closed

miketaylr opened this issue Dec 21, 2015 · 4 comments

Assignees

Member

miketaylr commented Dec 21, 2015

Splitting #879 into two bugs here to make it easier to review.

The new backend should be able to handle regular file uploads, as well as incoming screenshots from the add-ons, do image format validation, and save them to the filesystem.

Member Author

miketaylr commented Dec 21, 2015

I think this will actually make #710 a lot easier. @karlcow and I talked about doing this in Orlando as part of that, so hopefully I beat him to it and haven't duplicated his efforts here.

miketaylr pushed a commit that referenced this issue


          Issue #882. Fix error in ImportError exception.

8e0aa3d

miketaylr pushed a commit that referenced this issue


          Issue #882. Write our own Upload and UploadNotAllowed classes.

c0fecfa

This will allow us to get rid of Flask-Upload.

miketaylr pushed a commit that referenced this issue


          Issue #882. Remove Flask-Uploads.

87b3ff4

miketaylr pushed a commit that referenced this issue


          Issue #882. Use new Upload class for image/screenshot uploads.

2f567ab

miketaylr pushed a commit that referenced this issue


          Issue #882. Set MAX_CONTENT_LENGTH to handle max upload size.

6259b4c

miketaylr pushed a commit that referenced this issue


          Issue #882. Import new ALLOWED_FORMATS into form.py

0e929fe

miketaylr pushed a commit that referenced this issue


          Issue #882. Abstract out a thanks method into helpers.py

b41a3e3

miketaylr pushed a commit that referenced this issue


          Issue #882. Hook up screenshots into the uploads mechanism.

c9a0dfd

(request.form['screenshot'] is added in bugform.js, which will
added in #879)

miketaylr pushed a commit that referenced this issue


          Issue #882. Fix bug in get_filename.

Member Author

miketaylr commented Dec 21, 2015

Note: I need to test this stuff in the context of filing issues, locally I was just making sure the upload stuff worked/was saved to file.

miketaylr pushed a commit that referenced this issue


          Issue #882. Fix error in ImportError exception.

77dc70f

miketaylr pushed a commit that referenced this issue


          Issue #882. Write our own Upload and UploadNotAllowed classes.

4c52605

This will allow us to get rid of Flask-Upload.

miketaylr pushed a commit that referenced this issue


          Issue #882. Remove Flask-Uploads.

7c21401

miketaylr pushed a commit that referenced this issue


          Issue #882. Use new Upload class for image/screenshot uploads.

a10a45b

miketaylr pushed a commit that referenced this issue


          Issue #882. Set MAX_CONTENT_LENGTH to handle max upload size.

952f44f

miketaylr pushed a commit that referenced this issue


          Issue #882. Import new ALLOWED_FORMATS into form.py

bb830bc

miketaylr pushed a commit that referenced this issue


          Issue #882. Abstract out a thanks_page method into helpers.py

be7b402

miketaylr pushed a commit that referenced this issue


          Issue #882. Hook up screenshots into the uploads mechanism.

d65e0cc

(request.form['screenshot'] is added in bugform.js, which will
added in #879)

Member Author

miketaylr commented Dec 21, 2015

Locally, "regular" file upload images is working but the screenshot stuff isn't when filing a new issue.

To investigate.

miketaylr pushed a commit that referenced this issue


          Issue #882. Import TestingFileStorage from Flask-Uploads.

d75ccc7

miketaylr pushed a commit that referenced this issue


          Issue #882. Fix error in ImportError exception.

miketaylr pushed a commit that referenced this issue


          Issue #882. Write our own Upload and UploadNotAllowed classes.

54cf881

This will allow us to get rid of Flask-Upload.

miketaylr pushed a commit that referenced this issue


          Issue #882. Remove Flask-Uploads.

c19f11f

miketaylr pushed a commit that referenced this issue


          Issue #882. Use new Upload class for image/screenshot uploads.

7d7e257

miketaylr pushed a commit that referenced this issue


          Issue #882. Set MAX_CONTENT_LENGTH to handle max upload size.

169d1a7

miketaylr pushed a commit that referenced this issue


          Issue #882. Import new ALLOWED_FORMATS into form.py

c63414e

miketaylr pushed a commit that referenced this issue


          Issue #882. Abstract out a thanks_page method into helpers.py

c91e2de

miketaylr pushed a commit that referenced this issue


          Issue #882. Hook up screenshots into the uploads mechanism.

6c540db

(request.form['screenshot'] is added in bugform.js, which will
added in #879)

miketaylr pushed a commit that referenced this issue


          Issue #882. Import TestingFileStorage from Flask-Uploads.

cb3f6d7

miketaylr self-assigned this

miketaylr added the status: in progress label

miketaylr pushed a commit that referenced this issue


          Issue #882. Update config.py.example with some sensible defaults for …

e38df5a

…uploads.

miketaylr mentioned this issue

Log screenshot vs image upload #884

Closed

miketaylr pushed a commit that referenced this issue


          Issue #882. Use PIL and address a bunch of @karlcow's feedback.

747e77b

(this commit is gonna get squashed into previous ones, but leaving
like this to help with review)

miketaylr pushed a commit that referenced this issue


          Issue #882. Fix error in ImportError exception.

ced79e4

miketaylr pushed a commit that referenced this issue


          Issue #882. Remove Flask-Uploads and write our own Upload class.

b090a31

miketaylr pushed a commit that referenced this issue


          Issue #882. Update config.py.example with some sensible defaults for …

0b3cdfb

…uploads.

miketaylr pushed a commit that referenced this issue


          Issue #882. Set MAX_CONTENT_LENGTH to handle max upload size.

4f41833

miketaylr pushed a commit that referenced this issue


          Issue #882. Update CONTRIBUTING to link to Pillow deps.

f7e773a

miketaylr pushed a commit that referenced this issue


          Issue #882. Abstract out a thanks_page method into helpers.py

e14cdbe

miketaylr pushed a commit that referenced this issue


          Issue #882. Hook up screenshots into the uploads mechanism.

637aa01

(request.form['screenshot'] is added in bugform.js, which will
added in #879)

miketaylr pushed a commit that referenced this issue


          Issue #882. Import TestingFileStorage from Flask-Uploads.

d85ec09

miketaylr pushed a commit that referenced this issue


          Issue #882. Fix error in ImportError exception.

7feadf6

miketaylr pushed a commit that referenced this issue


          Issue #882. Remove Flask-Uploads and write our own Upload class.

f592ada

miketaylr pushed a commit that referenced this issue


          Issue #882. Update config.py.example with some sensible defaults for …

8a05b19

…uploads.

miketaylr pushed a commit that referenced this issue


          Issue #882. Set MAX_CONTENT_LENGTH to handle max upload size.

160cd5a

miketaylr pushed a commit that referenced this issue


          Issue #882. Update CONTRIBUTING to link to Pillow deps.

d44f505

miketaylr pushed a commit that referenced this issue


          Issue #882. Abstract out a thanks_page method into helpers.py

020a2e5

miketaylr pushed a commit that referenced this issue


          Issue #882. Hook up screenshots into the uploads mechanism.

e041a27

(request.form['screenshot'] is added in bugform.js, which will
added in #879)

miketaylr pushed a commit that referenced this issue


          Issue #882. Import TestingFileStorage from Flask-Uploads.

6da27ca

miketaylr pushed a commit that referenced this issue


          Issue #882. Raise IOError by default in to_image_object

4b27442

miketaylr pushed a commit that referenced this issue


          Issue #882. Re-write upload tests to use fixture files.

29f3480

This way Pillow can test if they're actually valid or not.

miketaylr pushed a commit that referenced this issue


          Issue #882. Add tests for base64 screenshot uploads.

miketaylr closed this as completed in

61611bd

miketaylr removed the status: in progress label

This was referenced Dec 28, 2015

Optimizing images when uploading to the server #710

Closed

Add a screenshot to the browser extensions #452

Closed

Member

karlcow commented Dec 29, 2015

👏😂🙇🏼. Time for 🍔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment