Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused instance of request_headers #862

Closed
karlcow opened this issue Dec 15, 2015 · 0 comments
Closed

Removing unused instance of request_headers #862

karlcow opened this issue Dec 15, 2015 · 0 comments
Assignees
@karlcow
Labels
prio: good first bug

Comments

@karlcow
Copy link
Member

karlcow commented Dec 15, 2015

See the discussion with @miketaylr at de00259#diff-b9ca02974fd8e51b2c21afc1f20d62b5L53

The current instance of the code

webcompat.com/webcompat/api/endpoints.py

Line 46 in 5b376a2

request_headers = get_request_headers(g.request_headers)

sports a unused request_headers to be removed.

Bonus:

  • Remove from flask.ext.github import GitHubError
  • Remove from webcompat import github

😁
karlcow added a commit to karlcow/webcompat.com that referenced this issue Dec 16, 2015
@karlcow
webcompat#862 fixes unused import
341f25a
karlcow added a commit to karlcow/webcompat.com that referenced this issue Dec 16, 2015
@karlcow
webcompat#862 removes unused variable
b8a4d5a
karlcow added a commit to karlcow/webcompat.com that referenced this issue Dec 16, 2015
@karlcow
webcompat#862 removes unused helper
73ab1cc
@karlcow karlcow self-assigned this Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlcow karlcow

Labels
prio: good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow