Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about using "[ci skip]" for doc updates, etc. #509

Closed
karlcow opened this issue Dec 24, 2014 · 4 comments
Closed

Add note about using "[ci skip]" for doc updates, etc. #509

karlcow opened this issue Dec 24, 2014 · 4 comments

Comments

@karlcow
Copy link
Member

karlcow commented Dec 24, 2014

When we are pushing commits, travis will repeat its dance for every single one, even when there is nothing to test, such as docs. etc.

There are two possibilities to manage this:

  • ci skip

    Commits that have [ci skip] anywhere in the commit messages will be ignored. [ci skip] does not have to appear on the first line, so it is possible to use it without polluting your project's history.

  • blacklist some branches
    We could imagine to have things like:
branches:
    except:
        - /^doc.*$/

and using always docIssueNumber for a branch which is about doc and other type of conventions.

@miketaylr
Copy link
Member

If you push a branch with say, 10 commits it will only build for the last one. Seems useless for changes to the CHANGELOG, etc., but it doesn't really cost us anything.

But feel free to use ci skip in your commit messages. Good to know. Not sure what action there is for this bug.

@karlcow
Copy link
Member Author

karlcow commented Dec 25, 2014

The action could have been the second option. Configure the travis config file if we are adopting names for branches OR to add a line in the doc to inform people about ci skip for the last commit in the branch. :)

@miketaylr
Copy link
Member

I prefer the 2nd option, if someone would like to update docs. IMO having a branch naming convention seems like too much process for what we gain (and if you forget or do it incorrectly, there's not much point to it).

@miketaylr miketaylr changed the title Travis useless builds/tests on documentation. Add note about using "[ci skip]" for doc updates, etc. Jan 6, 2015
@miketaylr
Copy link
Member

I went ahead and just pushed this to master.

miketaylr pushed a commit that referenced this issue Jul 20, 2015
* master: (46 commits)
  Fixes #509 - mention [ci skip] in docs.
  v1.6.2 changelog
  Issues #588 - list style
  Fix #583 Using the function for checking dependencies
  Checking dependencies
  Modules needed for checking dependencies
  Two cases to handle
  Adding message
  Issue #368 - Remove (now) unused STARTUP variable
  Issue #368 - Compute cache busting param based on md5 hash of file
  Issue #368 - Move bust_cache function into a Jinja template helper
  Issue #368: Part 1, add bust_cache param to minified production JS
  Issue #587 - Add a task to check npm dependencies and run by default
  v1.6.1
  Fixes #591 - Typo in form field. >_<
  Tag v1.6.0
  Issue #572 - Remove right float for GitHub issue warp hint
  Issue #432 - Add js-form-error and js-no-error classes and update tests.
  Issue #432 - Add wc-Form-required class to problem label
  Added wc-Form, wc-ReportForm
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants