Functional tests fail starting with a certain test

[magsout]

The tests fail on all branches. It would appear that the tests fail from: Going back in history updates issue list and URL state

× firefox on any platform - Issue-list - Going back in history updates issue list and URL state

Fx ANY: [✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓×××××✓✓✓✓×××✓\ ] 65/78, 15 fail

[zoepage]

@miketaylr @brizental
Would one of you be able to take a look here? Thanks!

[miketaylr]

I don't think this reproduces for me. @brizental does it for you?

[brizental]

I just changed from Ubuntu to MacOS and this has started happening to me too... I'll have a look, now that I can reproduce it.

[miketaylr]

whoops, this reproduces for me now (using v54 stable):

[miketaylr]

Failing test starts here: https://github.com/webcompat/webcompat.com/blob/master/tests/functional/issue-list-non-auth.js#L290

[brizental]

The problem is that the goBack() function (https://github.com/webcompat/webcompat.com/blob/master/tests/functional/issue-list-non-auth.js#L320) should return a Promise but it never returns anything.

I tried to look and see if the problem is in our code, but I didn't find anything wrong, so I think that this might be a problem in Leadfoot, it only happens for the newest Firefox versions, like 54 and forward. I also tried to mess around with Leadfoot's code, but didn't have success.

Apparently everything is working fine, the URL changes right as it should and everything, it just gets stuck in some Promise limbo and never gets to the next line (https://github.com/webcompat/webcompat.com/blob/master/tests/functional/issue-list-non-auth.js#L321). Also if you manually refresh the page when it gets stuck it gets going again.

I'll keep on investigating, but just wanted to see if anybody has any ideia of what might be happening :)

[miketaylr]

so I think that this might be a problem in Leadfoot, it only happens for the newest Firefox versions, like 54 and forward.

It's also possible it's a Geckodriver bug or regression: https://github.com/mozilla/geckodriver