Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing the comment box design #1261

Closed
karlcow opened this issue Dec 26, 2016 · 7 comments
Closed

Polishing the comment box design #1261

karlcow opened this issue Dec 26, 2016 · 7 comments

Comments

@karlcow
Copy link
Member

karlcow commented Dec 26, 2016

In the 2016 design iteration, the comment box looks like:
capture d ecran 2016-12-26 a 14 31 50

We knew it when we deployed the new version. It is time to fix it. 🤖

remove the textarea border

.wc-Comment-submit {
	font-size: 1rem;
	display: block;
	width: 100%;
	min-height: 128px;
	/* border-color: rgb(194, 194, 194); */
	/* border-style: solid solid dashed; */
	border-width: 0;
	padding: 1em;
	resize: vertical;
}

capture d ecran 2016-12-26 a 14 38 26

Proposal for images upload.

.wc-UploadForm--new {
	min-height: 35px;
	background-color: rgb(64, 64, 64);
	display: flex;
}

.wc-UploadForm {
	display: block;
	position: relative;
	text-align: center;
	min-height: 250px;
	cursor: pointer;
	z-index: 3;
}

.wc-UploadForm-wrapper {
	z-index: 2;
	margin-top: 1rem;
	padding: 1rem;
	border: 2px dashed rgb(204, 204, 204);
	border-radius: 15px;
	align-content: center;
	align-items: center;
	margin: 1rem auto;
}
.wc-UploadForm-label {
	position: relative;
	display: inline-block;
	margin-bottom: 5px;
	color: rgb(204, 204, 204);
	font-weight: 700;
	cursor: pointer;
	text-decoration: underline;
}

capture d ecran 2016-12-26 a 15 06 24

@karlcow
Copy link
Member Author

karlcow commented Dec 26, 2016

Fixing the margin for buttons.

.wc-Form-group {
	position: relative;
	/* margin-bottom: 1.6em; */
}
.wc-Comment-button {
	text-align: right;
	margin: 0.6em 0 0;
}

capture d ecran 2016-12-26 a 15 15 45

@karlcow
Copy link
Member Author

karlcow commented Dec 26, 2016

The global overview for this proposal (open to comments).

capture d ecran 2016-12-26 a 15 16 47

@karlcow
Copy link
Member Author

karlcow commented Dec 26, 2016

For the buttons to be still centered when wider viewport

.wc-Comment-button {
	text-align: right;
	margin: 0.6em auto 0 auto;
	display: flex;
	flex-direction: row;
	justify-content: center;
}

.wc-Button {
	display: inline-block;
	margin-bottom: .5em;
	padding: .5em 2em;
	text-decoration: none;
	font-weight: 700;
	border-radius: 20px;
	color: rgb(0, 0, 0);
	text-align: center;
	vertical-align: middle;
	cursor: pointer;
	white-space: nowrap;
	font-size: inherit;
	line-height: normal;
	background-color: transparent;
	background-image: none;
	-webkit-user-select: none;
	-moz-user-select: none;
	-ms-user-select: none;
	user-select: none;
	-webkit-appearance: none;
	margin: 0 1em .5em 1em;
}

@karlcow
Copy link
Member Author

karlcow commented Dec 26, 2016

ping @magsout for any recommendations with regards to the CSS used.

@miketaylr
Copy link
Member

+1 for visual changes.

@magsout
Copy link
Member

magsout commented Dec 31, 2016

@karlcow design looks good 👍
For CSS:

  • for Color Hexadecimal instead
  • no PX, but em instead (except border-radius)
  • no prefix, thanks to postcss ;)

@karlcow
Copy link
Member Author

karlcow commented Dec 31, 2016

all the values came from my hacking directly on the current CSS once in the browser through developer tools. so the px, prefixes, etc were not from me. :) but understood for the recommendations. Thanks.

karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 5, 2017
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 5, 2017
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 5, 2017
@karlcow karlcow self-assigned this Jan 5, 2017
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants