Issue #2296 - send patch for lost commits

tests/unit/test_urls.py

@@ -97,11 +97,6 @@ def test_contact(self):
         rv = self.app.get('/contact')
         self.assertEqual(rv.status_code, 200)
 
-    def test_contact(self):
-        '''Test that /contact exists.'''
-        rv = self.app.get('/contact')
-        self.assertEqual(rv.status_code, 200)
-
     def test_activity_page_401_if_not_logged_in(self):
         """Test that asks user to log in before displaying activity."""
         rv = self.app.get('/me')

webcompat/static/css/src/form.css

@@ -4,7 +4,7 @@
 ----------------
 * DEPENDENCIES:
 ----------------
-* colors.css
+* variable.css
 */
 
 .form {

webcompat/static/css/src/grid.css

@@ -14,11 +14,7 @@
   margin: 0 calc(-1 / 2 * var(--unit-space)) var(--grid-outermargin-s);
 }
 
-.grid-row > .grid-row {
-  margin-left: 0;
-  margin-right: 0;
-}
-
+.grid-row > .grid-row,
 .grid-show-gap {
   margin-left: 0;
   margin-right: 0;
@@ -73,11 +69,6 @@
     margin-bottom: var(--grid-outermargin-m);
   }
 
-  /* .grid-nested {
-    display: flex;
-    flex-wrap: wrap;
-  } */
-
   .x1-fix {
     max-width: var(--unit-modul-s);
   }

webcompat/static/css/src/icons.css

@@ -1,4 +1,3 @@
-
 .icon {
   width: 16px;
   height: 16px;
@@ -17,6 +16,3 @@
 .illustration {
   max-width: 6em;
 }
-
-/* icons */
-

webcompat/static/css/src/issue.css

@@ -27,7 +27,7 @@
 }
 
 .issue-comment .comment-header {
-  padding: var(--unit-space) var(--unit-space);
+  padding: var(--unit-space);
   background-color: var(--color-bg-comment-header);
   display: flex;
   justify-content: space-between;
@@ -91,7 +91,7 @@
   overflow: auto;
 }
 
-/* As we can not add a class to the img right now (markup parsers are complicated), we need to use the element */
+/* As we can not add a class to the img in the comment right now (markup parsers are complicated), we need to use the img element */
 .comment-body img,
 .js-Issue-markdown img {
   max-width: calc(var(--unit-modul-m) - (var(--unit-space) * 4));

webcompat/static/css/src/issues-list.css

@@ -34,29 +34,17 @@
   text-decoration: underline;
 }
 
-/* .issue-description .issue-type {
-} */
-
-.issue-description .issue-date-open {
-  color: var(--color-default);
-  line-height: 1em;
-  font-size: .8em;
-  display: inline;
-}
-
-.issue-description .issue-date-closed {
+.issue-description .issue-date-open,
+.issue-description .issue-date-closed,
+.issue-description .issue-comments {
   color: var(--color-default);
   line-height: 1em;
   font-size: .8em;
   display: inline;
-  margin-left: calc(var(--unit-gap) / 3);
 }
 
+.issue-description .issue-date-closed,
 .issue-description .issue-comments {
-  color: var(--color-default);
-  line-height: 1em;
-  font-size: .8em;
-  display: inline;
   margin-left: calc(var(--unit-gap) / 3);
 }
 

webcompat/static/css/src/nav.css

@@ -38,10 +38,7 @@
   margin: 0 4px;
 }
 
-.nav-item:first-child {
-  margin: 0;
-}
-
+.nav-item:first-child,
 .nav-item:last-child {
   margin: 0;
 }

webcompat/static/css/src/tiles.css

@@ -4,7 +4,7 @@
 ----------------
 * DEPENDENCIES:
 ----------------
-* colors.css
+* variables.css
 */
 
 .hero-tile {

webcompat/static/js/lib/issues.js

@@ -253,19 +253,20 @@ issues.ImageUploadView = Backbone.View.extend({
       return;
     }
 
-    var inlineHelp = $("<span></span>", {
+    // what is wc-Form-helpInline???
+    var inlineHelp = $("<small></small>", {
       class: "wc-Form-helpInline",
       text: this.inputMap[id].helpText
     });
 
     this.inputMap[id].valid = false;
     $(this.inputMap[id].elm)
       .parents(".js-Form-group")
-      .removeClass("wc-Form-noError js-no-error")
-      .addClass("wc-Form-error js-form-error");
+      .removeClass("js-no-error")
+      .addClass("js-form-error");
 
     if (id === "image") {
-      inlineHelp.insertAfter(".wc-Form-label--upload");
+      inlineHelp.insertAfter(".js-label-upload");
     }
 
     this.disableSubmits();
@@ -274,9 +275,10 @@ issues.ImageUploadView = Backbone.View.extend({
     this.inputMap[id].valid = true;
     $(this.inputMap[id].elm)
       .parents(".js-Form-group")
-      .removeClass("wc-Form-error js-form-error")
-      .addClass("wc-Form-noError js-no-error");
+      .removeClass("js-form-error")
+      .addClass("js-no-error");
 
+    // this can probably go as we do not have wc- styles anymore?
     $(this.inputMap[id].elm)
       .parents(".js-Form-group")
       .find(".wc-Form-helpInline")