Partially revert "Implement parseHTMLUnsafe and setHTMLUnsafe" #43202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 17743f7. There is no reason for the Declarative Shadow DOM API tests to rely on these methods, and this reduces test coverage for browsers that don't support them. Per general policy, tests shouldn't be relying on unrelated features, especially when those other features lack interoperable cross-browser support.
wpt-pr-bot
requested review from
hayatoito,
kojiishi,
rniwa and
TakayoshiKochi
3 tasks
annevk
reviewed
Nov 16, 2023
| @@ -0,0 +1,4 @@ | |||
| function setInnerHTML(el,content) { | |||
| const fragment = (new DOMParser()).parseFromString(`<pre>${content}</pre>`, 'text/html', {includeShadowRoots: true}); | |||
There was a problem hiding this comment.
This is a non-standard API so I don't think this works.
There was a problem hiding this comment.
Right - this is the old version of parseHTMLUnsafe(), and it won’t be standardized.
There was a problem hiding this comment.
Only chrome added the includeShadowRoots parameter, right?
So these tests would have never worked before my test change anyway?
There was a problem hiding this comment.
WebKit had a preffed-off implementation, but I removed it.
I think @gsnedders is okay with closing this PR so I'll do that to avoid further confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 17743f7.
There is no reason for the Declarative Shadow DOM API tests to rely on these methods, and this reduces test coverage for browsers that don't support them. Per general policy, tests shouldn't be relying on unrelated features, especially when those other features lack interoperable cross-browser support.