[Gecko Bug 1676679] support virtual authenticator functions in webdriver #41377
Conversation
wpt-pr-bot
added
infra
webdriver
wg-testing_browser
wptrunner
moz-wptsync-bot
force-pushed
the
gecko/1676679
branch
from
0804a73 to
64dc14f
Compare
moz-wptsync-bot
force-pushed
the
gecko/1676679
branch
from
64dc14f to
dadf6ea
Compare
|
These failures here exist because no new version of marionette-driver has been released. I did that so lets see if tests are passing now. |
|
We will actually have to wait until dependabot created a PR for the marionette client release. |
|
The bump of marionette client happened last week via #41457. As such we can go ahead and get this PR merged. I'll try to push a rebase on top of this change. |
Depends on D185198 Differential Revision: https://phabricator.services.mozilla.com/D162624 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1676679 gecko-commit: d918661c17e3b35d0fdc71e621020e4f2fbf51dd gecko-reviewers: webdriver-reviewers, jgraham, whimboo
|
Tests for Firefox are passing now. @jgraham, @gsnedders or @DanielRyanSmith could one of you please admin merge? Thanks! |
After a week without a reply could some @web-platform-tests/admins please admin merge this PR? Note that the infra tests are broken because |
|
@whimboo Sorry, was OOO last week. Otherwise I'm usually be able to take care of these requests if/when the need arises. 🙂 |
|
No worries! Thanks a lot for merging! |
Could we somewhere better document that the expectations should be kept up-to-date? It would've been better to just update the infrastructure expectations? (c.f. https://github.com/web-platform-tests/wpt/tree/master/infrastructure) |
|
I tried to run these infrastructure tests locally and I cannot get them to pass. They still fail with After having a deeper look into the wptrunner code I noticed that we actually missed to implement all the virtual authenticator methods in executormarionette.py. Doing that locally actually make the infrastructure tests work for me as well. Sorry, that I didn't notice that. I'll have a PR ready soon as a follow-up to get this fixed. Thanks for noticing and reaching out! Edited: I totally missed to actually pull from upstream before checking that so it is clear why it wasn't working locally. Nevertheless a PR for updating the test expectations has been opened. |
…sts#41377) Depends on D185198 Differential Revision: https://phabricator.services.mozilla.com/D162624 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1676679 gecko-commit: d918661c17e3b35d0fdc71e621020e4f2fbf51dd gecko-reviewers: webdriver-reviewers, jgraham, whimboo Co-authored-by: Dana Keeler <[email protected]>
Depends on D185198
Differential Revision: https://phabricator.services.mozilla.com/D162624
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1676679
gecko-commit: af356c621a918b3dbd14ac75390d5915b3cc791b
gecko-reviewers: webdriver-reviewers, jgraham, whimboo