Save Transitions to use for back navigation #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmoelter
commented
Feb 26, 2018
| currentTransition = overridingTransition; | ||
| overridingTransition = null; | ||
| } else if (direction.equals(Direction.BACKWARD) && currentScreen().getLeaveTransition() != null) { | ||
| currentTransition = currentScreen().getLeaveTransition(); |
There was a problem hiding this comment.
I want to test this logic, but triggering the whenMeasured block is tough. I've tried manually calling measure and layout, but it's still not triggering it. Thoughts/suggestions?
|
This is the default behavior in the v2.0 betas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving transitions allow us to create interesting transitions later, in addition to just making sense. I'd rather not have to override back transitions too.
Saving transitions can be tricky when you can rewrite the backstack, so I decided to attach Transitions to screens so they can animate out in the same method they animate in. A mutable backstack in this case means that transitions must work with any to/from view, which is a reasonable restriction in my mind.