Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added other assets to bower main files and included bower.json in package #161

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Added other assets to bower main files and included bower.json in package #161

merged 2 commits into from
Nov 11, 2020

Conversation

juriejan
Copy link
Contributor

I've added the css, fonts and images to the main bower package files and included the bower.json file in the package. This would allow us to make use of tools that automatically hookup assets from Bower packages. (I'm currently using main-bower-files)

@Darex1991
Copy link

👍

Worked for me with:

bower install juriejan/raty --save

@wbotelhos
Copy link
Owner

Hi @juriejan ,

Could you rebase it?

@juriejan
Copy link
Contributor Author

juriejan commented Nov 11, 2020

Done @wbotelhos! ✌

@wbotelhos wbotelhos merged commit 1e700b5 into wbotelhos:master Nov 11, 2020
@wbotelhos
Copy link
Owner

wbotelhos commented Nov 11, 2020

Thank you @juriejan ! :)

Do I need to generate a version or its works on the master?

@juriejan
Copy link
Contributor Author

Not sure I understand the question @wbotelhos. I guess you can just attach it to any version you choose.

@wbotelhos
Copy link
Owner

wbotelhos commented Nov 11, 2020

I don't know if Bower needs a tagged version to work or if it works just being on the master branch.

@juriejan
Copy link
Contributor Author

I'm also not sure. Haven't used Bower for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants