Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar and snippets #21

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Conversation

dcodeIO
Copy link
Contributor

@dcodeIO dcodeIO commented Jan 23, 2020

  • Remove no longer valid instructions
  • Support all current instructions, incl. experimental ones in the wild
  • Support non-standard Binaryen extensions in its s-expr format
  • Recognize ids as of the spec
  • Recognize ids referring to a function name
  • Add floating point literals
  • Fix whitespace
  • Fix snippet warnings

Still not perfect and probably the most horrible PR diff I've proposed in a while. Would totally understand if that's not a PR you are comfortable with, yet didn't know what else to do with all of this.

Is this something you'd consider?

@syrusakbary
Copy link
Member

The PR looks good. The change on whitespaces makes it a bit harder to follow up, but I think it should be ok.

Let me know once is ready to review :)

@dcodeIO dcodeIO marked this pull request as ready for review January 23, 2020 22:31
@dcodeIO
Copy link
Contributor Author

dcodeIO commented Jan 23, 2020

Ok, great! I think it's good for reviewing. What I'm unsure about are the pattern names like storage.type.wat and so on. Some sources say so, others say so.

@syrusakbary syrusakbary merged commit 63e8f6d into wasmerio:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants