-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Wagtail 2.15 #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and tidy up the icon for the links block
compatible as in allowed to install on <2.16
for Django 3.x compatibility
Now on staging |
Stormheg
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zerolab 🙌
All seems sensible. A few Django system check warnings remain, but those are related to wagtail_ab_testing
.
- Tested with local vagrant box and an older database dump.
- unpins debian version - bumps gunicorn
`WAGTAILEMBEDS_FINDERS` is not using the embedly finder, so this is a moot dependency whic has not been updated in years
zerolab
force-pushed
the
chore/wagtail-215
branch
from
October 29, 2021 13:22
f973e19
to
a6a145f
Compare
@Stormheg thank you for the review/testing. I've submitted PRs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
currently blocked by wagtail-nest/wagtail-ab-testing#41