-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dark mode #76
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 88.44% 88.44%
=======================================
Files 15 15
Lines 753 753
Branches 140 140
=======================================
Hits 666 666
Misses 51 51
Partials 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jhonatan-lopes
Could you please include the create ab test form too? It has a couple bright areas in the headings. See the screenshot below.
I wouldn't bother with the help block at the bottom, the styling for that is provided by Wagtail. Wagtail appears to be missing dark mode styling for that
Hey @Stormheg, as we discussed, the "Create an A/B test" form is still using a template based on Wagtail 2.X which is not really great to work with in Wagtail >= 5.X. I believe we should update how we use this template to be compatible with the new UI/UX instead of trying to change the colours here, as detailed in #79. |
354fd7a
to
01be244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
$color-control
and$color-variant
--w-color-secondary-100
(#00B0B1
) as the control colour for dark themeFixes #62.
Results:
Chart:
Finished test:
Note: this PR targets Wagtail >=5.0 (when dark theme was introduced). When releasing a version with this patch, support for wagtail <5.0 should be dropped. Wagtail 4.1 LTS is EOL in a week (end of February) and devs are encouraged to migrate to 5.2 LTS.