Test for missing migrations #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgax
added a commit
to mgax/wagtail-ab-testing
that referenced
this pull request
Dec 13, 2023
Merged
Stormheg
force-pushed
the
test-for-missing-migrations
branch
from
e6962bc to
3cefd2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 15 15
Lines 732 732
Branches 137 137
=======================================
Hits 643 643
Misses 54 54
Partials 35 35 ☔ View full report in Codecov by Sentry. |
| from django.test import TestCase | ||
|
|
||
|
|
||
| class TestReportView(TestCase): |
There was a problem hiding this comment.
I believe the test class name here needs to be updated...
There was a problem hiding this comment.
Whoops, copypasta fail :) Thanks for spotting this!
|
I hadn't seen missing migrations being tested like this before, but it seems like an elegant solution 👍 I usually call the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if there are missing migrations and, if so, fail the test.