-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 and Django 5.0 #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don't think anyone would argue with dropping support for Django <4.2 going forward if that's something you need to do for e.g. feature support/maintenance simplicity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 15 15
Lines 732 732
Branches 137 137
=======================================
Hits 643 643
Misses 54 54
Partials 35 35 ☔ View full report in Codecov by Sentry. |
@@ -36,6 +36,7 @@ | |||
"Programming Language :: Python :: 3.9", | |||
"Programming Language :: Python :: 3.10", | |||
"Programming Language :: Python :: 3.11", | |||
"Programming Language :: Python :: 3.12", | |||
"Framework :: Django", | |||
"Framework :: Django :: 3.2", | |||
"Framework :: Django :: 4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgax could you please add the Django 5.0 trove classifier too?
setup.py
Outdated
"numpy>=1.19.4,<1.27", | ||
"scipy>=1.5.4,<1.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can open this up and make this <2
(Would be even more awesome if we could move the entire 'winner' calculation which requires these dependencies to the database and drop the need to install these heavyweight dependencies. Maybe some future day...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can open this up and make this
<2
Since we're using a tiny bit of the numpy/scipy APIs, this does seem like a low-risk change. I've loosened the constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
numpy
andscipy
to versions that can be installed in Python 3.12.