Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected UI issues with Wagtail 3.0 release #47

Closed
thibaudcolas opened this issue Apr 27, 2022 · 0 comments · Fixed by #61
Closed

Expected UI issues with Wagtail 3.0 release #47

thibaudcolas opened this issue Apr 27, 2022 · 0 comments · Fixed by #61

Comments

@thibaudcolas
Copy link

The Wagtail 3.0 first release candidate is out. There are large UI changes in this release, for which we have reviewed expected breakage in third-party UI customisations.

This is beyond what we do with our normal breaking changes policy, since the majority of those changes are on parts of Wagtail that haven’t been publicly supported / documented in any way. To make sure this goes smoothly anyway, I’m here to provide an advance notice of what we’re aware of with this specific package 🙂

For this package, there are no confirmed issues, but we would recommend taking a look at any reuse of core templates:

torchbox/wagtail-ab-testing/wagtail_ab_testing/templates/wagtail_ab_testing/compare.html
1:{% extends "wagtailadmin/base.html" %}
7:    {% include "wagtailadmin/shared/header.html" with title=title subtitle=page.title tabbed=1 merged=1 %}

torchbox/wagtail-ab-testing/wagtail_ab_testing/templates/wagtail_ab_testing/add_compare.html
1:{% extends "wagtailadmin/base.html" %}
7:    {% include "wagtailadmin/shared/header.html" with title=title subtitle=page.title icon='people-arrows' tabbed=1 merged=1 %}

torchbox/wagtail-ab-testing/wagtail_ab_testing/templates/wagtail_ab_testing/results.html
1:{% extends "wagtailadmin/base.html" %}
7:    {% include "wagtailadmin/shared/header.html" with title=title icon='people-arrows' tabbed=1 merged=1 %}
126:    {% include "wagtailadmin/pages/_editor_js.html" %}

torchbox/wagtail-ab-testing/wagtail_ab_testing/templates/wagtail_ab_testing/report.html
1:{% extends 'wagtailadmin/reports/base_report.html' %}

torchbox/wagtail-ab-testing/wagtail_ab_testing/templates/wagtail_ab_testing/add_form.html
1:{% extends "wagtailadmin/base.html" %}
7:    {% include "wagtailadmin/shared/header.html" with title=title subtitle=page.title icon='people-arrows' tabbed=1 merged=1 %}
19:                    {% include "wagtailadmin/shared/field_as_li.html" with field=form.name %}
20:                    {% include "wagtailadmin/shared/field_as_li.html" with field=form.hypothesis %}
44:                    {% include "wagtailadmin/shared/field_as_li.html" with field=form.sample_size %}
66:    {% include "wagtailadmin/pages/_editor_css.html" %}
70:    {% include "wagtailadmin/pages/_editor_js.html" %}

In particular, the header template no longer supports the tabbed attribute.

Stormheg added a commit to Stormheg/wagtail-ab-testing that referenced this issue Nov 5, 2023
Not supported anymore as of Wagtail 3.0.

See: wagtail-nest#47
@Stormheg Stormheg linked a pull request Nov 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant