Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator Guide: add instructions for installing multiple binaries #4860

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Validator Guide: add instructions for installing multiple binaries #4860

merged 5 commits into from
Aug 11, 2023

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented May 31, 2023 •
edited
Loading

PULL REQUEST

Overview

After extensive discussion (see here and here), it's been determined that we will be distributing multiple binaries along with polkadot. I'm updating the Validator Guide to reflect this.

In the future, to make it easier for validators to install multiple binaries, this guide may be the basis for some script if that is desired.

TODO

Related

paritytech/polkadot#7147
paritytech/polkadot#7284

mrcnski added 2 commits May 31, 2023 16:02
@mrcnski
Validator Guide: add instructions for installing multiple binaries
0f9927b 
After extensive discussion (see
[here](paritytech/polkadot#7147) and
[here](https://forum.polkadot.network/t/ux-of-distributing-multiple-binaries-take-2/2854)),
it's been determined that we will be distributing multiple binaries along with
`polkadot`. I'm updating the Validator Guide to reflect this. To make it easier
for validators, this may be the basis for some script in the future if that is
desired.
@mrcnski
Add a helpful note
aeba9d3
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/ux-of-distributing-multiple-binaries-take-2/2854/39

@mrcnski mrcnski mentioned this pull request Jun 6, 2023
Merged
@PierreBesson
Copy link
Contributor

@mrcnski if there is a need to set the --worker-path flag pointing to the path of the worker binaries when starting the node as a validator this needs to be clearly explicited in this doc. For now this is missing from this PR.

@mrcnski
Copy link
Contributor Author

mrcnski commented Aug 4, 2023

Thanks @PierreBesson! We tried to make it so that existing workflows work in a backwards-compatible way without further changes. The --workers-path option was added just-in-case, but shouldn't be necessary for any of the installation methods in the guide. I'm not sure if it's worth mentioning in the guide for that reason, or if it would just add noise. Feedback always welcome though. I've pushed an update.

@mrcnski mrcnski marked this pull request as ready for review August 6, 2023 09:06
wpank
wpank reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@wpank wpank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall would say this looks good - one thing would be to maybe add a small bit of context that polkadot now requires 3 binaries

@mrcnski mrcnski requested a review from wpank August 11, 2023 07:57
@DrW3RK DrW3RK merged commit 87f588c into w3f:master Aug 11, 2023
@mrcnski mrcnski mentioned this pull request Aug 21, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpank wpank wpank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrcnski @Polkadot-Forum @PierreBesson @wpank @DrW3RK