-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-pseudo-4] Define ::picker() #10865
Conversation
This was discussed here: w3c#10440
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly fine. A few comments below.
css-pseudo-4/Overview.bs
Outdated
|
||
The ''::picker()'' pseudo-element only matches when the <a>originating | ||
element</a> supports <a>base appearance</a> and has a popup picker. The | ||
specified <<ident>> must also match the unique picker name of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably be defining the term "unique picker name" (for other specs to reference), unless you think it should be defined somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Do you think that HTML should define the mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think HTML should define it.
This was discussed here: #10440