Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping for aria-braillelabel and aria-brailleroledescription #134

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Add mapping for aria-braillelabel and aria-brailleroledescription #134

merged 2 commits into from
Apr 14, 2023

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Jul 18, 2022 •
edited by pr-preview bot
Loading

@spectranaut spectranaut mentioned this pull request Jul 18, 2022
Closed
@spectranaut spectranaut mentioned this pull request Aug 3, 2022
Merged
spectranaut
spectranaut commented Aug 3, 2022
View reviewed changes
index.html Show resolved Hide resolved
aleventhal
aleventhal approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@aleventhal aleventhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IA2/ATK mappings look good.
We should ask Travis Leithead for feedback on the UIA mappings, file an issue at crbug.com for implemention them, and maybe ask MS to consider it as a feature request for Narrator.

index.html Show resolved Hide resolved
@spectranaut spectranaut force-pushed the aria-braille-attributes branch from 38954a3 to 960c3e1 Compare August 5, 2022 00:06
@spectranaut spectranaut mentioned this pull request Aug 22, 2022
Closed
cookiecrook
cookiecrook reviewed Aug 25, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
@spectranaut spectranaut force-pushed the aria-braille-attributes branch from 960c3e1 to 5055790 Compare August 25, 2022 18:36
@spectranaut
Copy link
Contributor Author

The IA2/ATK mappings look good. We should ask Travis Leithead for feedback on the UIA mappings, file an issue at crbug.com for implemention them, and maybe ask MS to consider it as a feature request for Narrator.

I was just checking to see if this bug was filed, and I see it is:
https://bugs.chromium.org/p/chromium/issues/detail?id=1352278&q=aria-braille&can=2

@spectranaut spectranaut merged commit 6b3c186 into main Apr 14, 2023
github-actions bot added a commit that referenced this pull request Apr 14, 2023
@spectranaut @github-actions
Add mapping for aria-braillelabel and aria-brailleroledescription (#134)
8d8be33 
SHA: 6b3c186
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookiecrook cookiecrook cookiecrook left review comments

@jnurthen jnurthen jnurthen approved these changes

@aleventhal aleventhal aleventhal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spectranaut @cookiecrook @aleventhal @jnurthen