fix[ux]: shorten interface name in error messages #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyper/semantics/types/module.py
Outdated
|
|
||
| def __repr__(self): | ||
| return f"interface {self._id}" | ||
| return f"interface {Path(self._id).stem}" |
There was a problem hiding this comment.
i think we want to change the str implementation, but not repr -- repr should attempt to be injective back to interfaces
There was a problem hiding this comment.
i changed _pp_signature to use str, i think that should be okay cause its only used for error messages
charles-cooper
changed the title
| @@ -79,7 +80,7 @@ def abi_type(self) -> ABIType: | |||
| return ABI_Address() | |||
|
|
|||
| def __str__(self): | |||
| return self._id | |||
| return Path(self._id).stem | |||
There was a problem hiding this comment.
what if the type is aliased? e.g.
from ethereum.ercs import IERC20 as BROWNBEAR
There was a problem hiding this comment.
right, that would show the ierc20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Change the string representation of interfaces to a name instead of a path. Fix #4237 and #4299.
How I did it
Use only a part of
_idas the interface's string representation.How to verify it
Test that the interface either shows as
nameorinterface name.Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture