fix[ux]: IERC20Detailed inherits from IERC20
#4349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fe609dc.
AlbertoCentonze
changed the title
ERC20 and ERC20DetailedERC20 and ERC20Detailed
AlbertoCentonze
changed the title
ERC20 and ERC20DetailedERC20 and ERC20Detailed
charles-cooper
changed the title
ERC20 and ERC20DetailedIERC20Detailed
|
this looks good. can you add/update tests as appropriate? |
AlbertoCentonze
changed the title
IERC20DetailedIERC20Detailed inherits from ERC20
AlbertoCentonze
changed the title
IERC20Detailed inherits from ERC20IERC20Detailed inherits from IERC20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ERC20Detailedshould inherit fromERC20.How I did it
Given Vyper does not support inheritance I just added
implements: ERC20and copy pasted the methods fromERC20.vyiHow to verify it
Make a mock contract that implements the builtin
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture