Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create eth-watcher-ts based watcher for ERC20 contracts #4

Open
ashwinphatak opened this issue May 11, 2021 · 3 comments
Open

Create eth-watcher-ts based watcher for ERC20 contracts #4

ashwinphatak opened this issue May 11, 2021 · 3 comments
Assignees
@ramilexe @n0cte

Comments

@ashwinphatak
Copy link
Collaborator

No description provided.

@ramilexe
Copy link
Contributor

On the last conversation with Rick about splitting eth-watcher-ts code to library and application Rick said @ashwinphatak will provide application design how to separate lib logic and application. Is it completed?
If not what components of eth-watcher-ts should be moved to vdb-sdk and used in ERC20 watcher implementation?

@AFDudley
Copy link
Contributor

please just do the work Ashwin is asking for now and don't worry about splitting the code. Please satisfy the requirements Ashwin has provided as quickly as possible.

@ramilexe
Copy link
Contributor

Not sure I have a clear understanding of these requirements.

  1. eth-watcher-ts stores configuration in a database and has a specific database structure. It supports watching for multiple contracts (tables like contract.abi, contract.events, contract.contract). Do we want to keep the same DB schema?
  2. How to reuse eth-watcher-ts code in ERC20 watcher?
  3. What are the acceptance criteria for this task?

ashwinphatak pushed a commit that referenced this issue Jun 7, 2022
@nikugogoi @prathamesh0
Performance improvements in uni-info-watcher event processing (#348)
8410da4 
* Avoid loading relations when fetching entity in mapping code

* Load relations for Position entity separately in nfpm mapping code

* Remove join table for token whitelistPools and save as array of ids

* Add indexing of token properties in erc20-watcher and fix smoke-tests (#4)

* Add indexing of token properties in erc20-watcher

* Fix uni-info-watcher smoke-test

* Fix for saving token whitelistPools as array of ids

* Replace eth calls in uni-info-watcher with storage calls (#5)

* Remove entity relation foreign keys and only save entity id

* Use only typeorm delete for removeEntities

* Implement CLI for checking config endpoints

Co-authored-by: prathamesh0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramilexe ramilexe

@n0cte n0cte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ashwinphatak @AFDudley @ramilexe @n0cte