Warn when defining a method with same name as a prop #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's was great 👍🏼 |
posva
requested changes
Feb 17, 2017
src/core/instance/state.js
Outdated
| } | ||
| if (props && hasOwn(props, key)) { | ||
| warn( | ||
| `method "${key}" has already been defined as a property value.`, |
There was a problem hiding this comment.
simply say as a prop it's clearer and already in other warnings 🙂
|
@posva thanks for the feedback. Updated. |
kazupon
approved these changes
Feb 18, 2017
posva
approved these changes
Feb 18, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you specify a method on a component with the same name as a prop you get an error about mutating a prop directly, but it can be hard for people new to vue to figure out what this means.
This PR adds a more explicit warning message indicating exactly what went wrong.