support $on multi event - #4856 #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
reviewed
Feb 6, 2017
There was a problem hiding this comment.
Please update flowtype of $on
https://github.com/vuejs/vue/blob/dev/flow/component.js#L39
|
@kazupon oh sorry... |
yyx990803
requested changes
Feb 6, 2017
src/core/instance/events.js
Outdated
| // instead of a hash lookup | ||
| if (hookRE.test(event)) { | ||
| vm._hasHookEvent = true | ||
| const events: Array<string> = Array.isArray(event) ? event : [event] |
There was a problem hiding this comment.
I'd prefer using for loop only when it's an Array instead of always turning it into an Array.
In the loop you can just do this.$on(events[i], fn)
Kingwl
force-pushed
the
multi-event-on
branch
from
ec551b0 to
a5b12c4
Compare
Kingwl
force-pushed
the
multi-event-on
branch
from
a5b12c4 to
7bf739b
Compare
yyx990803
approved these changes
Feb 15, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4856