filter division expression with parentheses (fix #4838) #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the last commit message is wrong. I mean that I miss a lint check that's why the check failed before |
|
@rixlabs Don't worry for that. We'll probably squash it just do one, clean, commit 😄 |
|
|
||
| it('handle division with dot', () => { | ||
| const vm = new Vue({ | ||
| template: `<div>{{ 20. / 5 | double }}</div>`, |
There was a problem hiding this comment.
what about {{ a++ / 5 }} and {{ privateVar__ / 5}}?
Template string or object literal probably does not need to be considered, IMHO,
There was a problem hiding this comment.
I didn't considered + and - and also _ I have to include those too
There was a problem hiding this comment.
made a quick test checking every single exception with /[\w).\]\+\-\_$]/ and it's working.
Maybe there is a more generic way to do this
|
now I also search for + - _ also sync the repo |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter parser wasn't considering "closing" parentheses in the check for regex.
Fix for issue #4838